Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tensorflow-cc project to bazel-bench #934

Merged
merged 45 commits into from Mar 17, 2020
Merged

Add tensorflow-cc project to bazel-bench #934

merged 45 commits into from Mar 17, 2020

Conversation

joeleba
Copy link
Member

@joeleba joeleba commented Feb 10, 2020 •
edited

Example report: https://perf.bazel.build/tensorflow-cc/2020/02/06/report.html

Also lay some ground works to make it easier to add other projects in the future:

  • Use the new bazel-bench flag --project_label
  • Use the new bazel-bench flag --bazel_bench_extra_options
  • Limit available platforms to macos and ubuntu1804
  • Fix a bug where bazel binaries for ubuntu1804 wasn't reused (because it was using centos7's binary.

@joeleba joeleba marked this pull request as ready for review February 10, 2020 20:33
@joeleba joeleba changed the title Add tensorflow-cc project Add tensorflow-cc project to bazel-bench Feb 10, 2020
@philwo philwo force-pushed the master branch 2 times, most recently from f67a23f to 16b4e3d Compare February 17, 2020 18:51
philwo
philwo approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@philwo philwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is this ready to merge? (Sorry for the long delay.)

@joeleba
Copy link
Member Author

joeleba commented Mar 17, 2020

Yes, it's ready.

@philwo philwo merged commit c590f73 into bazelbuild:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philwo philwo philwo approved these changes

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeleba @philwo