Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure BuildKite release pipeline works without git notes #935

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@meteorcloudy
Copy link
Member

meteorcloudy commented Feb 12, 2020

We will not rely on git notes for getting release information, instead
we rely on parsing the release branch name. Therefore, we should make
sure the branch name is correct. But we still keep fetchting the git
notes in case we want to do patch release on older branches.

We will not rely on git notes for getting release information, instead
we rely on parsing the release branch name. Therefore, we should make
sure the branch name is correct. But we still keep fetchting the git
notes in case we want to do patch release on older branches.
@meteorcloudy meteorcloudy requested a review from philwo Feb 12, 2020
@meteorcloudy meteorcloudy requested a review from fweikert as a code owner Feb 12, 2020
@meteorcloudy meteorcloudy changed the title Make sure Build Kite release pipeline works without git notes Make sure BuildKite release pipeline works without git notes Feb 12, 2020
@philwo
philwo approved these changes Feb 12, 2020
@philwo philwo merged commit 5e9ee42 into master Feb 12, 2020
2 checks passed
2 checks passed
buildkite/continuous-integration Build #1284 passed (22 seconds)
Details
cla/google All necessary CLAs are signed
@philwo philwo deleted the fix_bazel_release_without_git_notes branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.