Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main repo target parsing #4009

Merged
merged 1 commit into from Oct 20, 2022

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 11, 2022

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #4008

Description of this change

This commit ensures that main repository target expressions such as @//foo:test can be parsed correctly. Since
bazelbuild/bazel@b1113f8, these are emitted by Bazel by default.

This commit ensures that main repository target expressions such as
`@//foo:test` can be parsed correctly. Since
bazelbuild/bazel@b1113f8,
these are emitted by Bazel by default.
@fmeum fmeum force-pushed the fix-main-repo-label-parsing branch from a949a56 to 0392b2b Compare October 11, 2022 09:22
@fmeum fmeum marked this pull request as ready for review October 11, 2022 09:28
@sgowroji sgowroji added product: IntelliJ IntelliJ plugin awaiting-review Awaiting review from Bazel team on PRs labels Oct 11, 2022
@mai93 mai93 merged commit 7043364 into bazelbuild:master Oct 20, 2022
@fmeum fmeum deleted the fix-main-repo-label-parsing branch October 20, 2022 20:14
cpsauer pushed a commit to hedronvision/bazelbuild-intellij that referenced this pull request Oct 24, 2022
This commit ensures that main repository target expressions such as
`@//foo:test` can be parsed correctly. Since
bazelbuild/bazel@b1113f8,
these are emitted by Bazel by default.
@jastice jastice removed the awaiting-review Awaiting review from Bazel team on PRs label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants