Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix generic comparisons on protobuf messages #93
Generated protobuf messages contain internal data structures
Fix all usages by either calling proto.Equal directly if
Generated protobuf messages contain internal data structures that general purpose comparison functions (e.g., reflect.DeepEqual, pretty.Compare, etc) do not properly compare. It is already the case today that these functions may report a difference when two messages are actually semantically equivalent. Fix all usages by either calling proto.Equal directly if the top-level types are themselves proto.Message, or by calling cmp.Equal with the cmp.Comparer(proto.Equal) option specified. This option teaches cmp to use proto.Equal anytime it encounters proto.Message types.
Thank you for cleaning this up!
Sure, will do! Thank you!…
On Sat, Nov 9, 2019 at 7:57 PM Joe Tsai ***@***.***> wrote: Would you be willing to make this change for me? I need to make these trivial changes to a number of projects and I don't have the bandwidth to setup the right developer environment for each one. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#93?email_source=notifications&email_token=AGFAVOEGHOR7JPQPHXKV4FDQS5L6XA5CNFSM4JJ4WAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUSV5Q#issuecomment-552151798>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGFAVOCFPG7HPSL2NJIVJQ3QS5L6XANCNFSM4JJ4WAJQ> .