New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify semantics of CancelOperation #30

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@ola-rozenfeld
Collaborator

ola-rozenfeld commented Oct 11, 2018

The Operations API specifies the use of the error field on the Operation proto in case the operation was cancelled. However, for our API, we want to remove all uses of this field, and use the ExecuteResponse.status instead. Therefore, we need to explicitly specify what should happen in case the server implements CancelOperation (which it doesn't have to!) and it was called for the given exeution.

@googlebot googlebot added the cla: yes label Oct 11, 2018

@ola-rozenfeld

This comment has been minimized.

Collaborator

ola-rozenfeld commented Oct 11, 2018

@t-chaik, FYI.

@ola-rozenfeld

This comment has been minimized.

Collaborator

ola-rozenfeld commented Oct 11, 2018

Also: @buchgr and @bergsieker

@ola-rozenfeld ola-rozenfeld merged commit 8014002 into bazelbuild:master Oct 16, 2018

1 check passed

cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment