Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with bazel 0.23.0 #333

Open
jianglai opened this Issue Feb 27, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@jianglai
Copy link

jianglai commented Feb 27, 2019

The title says it all. With bazel 0.23.0 I got the following output:

Extracting Bazel installation...
Starting local Bazel server and connecting to it...
ERROR: /usr/local/google/home/jianglai/.cache/bazel/_bazel_jianglai/c52ec6282bd27be0bdbeba205586bf1a/external/io_bazel_rules_closure/closure/compiler/closure_js_deps.bzl:82:17: Traceback (most recent call last):
        File "/usr/local/google/home/jianglai/.cache/bazel/_bazel_jianglai/c52ec6282bd27be0bdbeba205586bf1a/external/io_bazel_rules_closure/closure/compiler/closure_js_deps.bzl", line 78
                rule(implementation = _impl, attrs = {"...")}, ..."})
        File "/usr/local/google/home/jianglai/.cache/bazel/_bazel_jianglai/c52ec6282bd27be0bdbeba205586bf1a/external/io_bazel_rules_closure/closure/compiler/closure_js_deps.bzl", line 82, in rule
                attr.label_list(cfg = "data", allow_files = True)
Using cfg = "data" on an attribute is a noop and no longer supported. Please remove it. You can use --incompatible_disallow_data_transition=false to temporarily disable this check.
ERROR: error loading package '': in /usr/local/google/home/jianglai/.cache/bazel/_bazel_jianglai/c52ec6282bd27be0bdbeba205586bf1a/external/io_bazel_rules_closure/closure/defs.bzl: Extension file 'closure/compiler/closure_js_deps.bzl' has errors
ERROR: error loading package '': in /usr/local/google/home/jianglai/.cache/bazel/_bazel_jianglai/c52ec6282bd27be0bdbeba205586bf1a/external/io_bazel_rules_closure/closure/defs.bzl: Extension file 'closure/compiler/closure_js_deps.bzl' has errors
INFO: Elapsed time: 10.116s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

I'm using rules_closure 0.8.0. I think the latest version in master already fixed it (it does not have cfg = "data" in closure_js_deps.bzl, which is what bazel complained about. Maybe this can be fixed simply by cutting a new release?

@jianglai

This comment has been minimized.

Copy link
Author

jianglai commented Feb 27, 2019

@laurentlb laurentlb added the P1 label Feb 27, 2019

@laurentlb

This comment has been minimized.

Copy link
Collaborator

laurentlb commented Feb 27, 2019

Correct. Everything should work at head (we have lots of tests for that - any failure would block a Bazel release). The latest release is a bit old (August) and we've made lots of fixes since that.

I can recommend you to use the latest commit (87d24b1) in your repository, this should unblock you. But we should also have a new release in the next few days.

jianglai added a commit to google/nomulus that referenced this issue Mar 9, 2019

Update to bazel 0.23.1
Also updated closure rules to GitHub master, as the current release version
(0.80.0) has compatibility issues with bazel 0.23.1.

See: bazelbuild/rules_closure#333

Note that on Debian Testing (Buster) there's currently an issue with OpenSSL that can be temporarily fixed by setting the environment variable OPENSSL_CONF to /etc/ssl.

See: https://fransdejonge.com/2018/12/run-enpass-on-debian-buster-testing/

Lastly, migrated from the --local_resources flag (to be deprecated) to --local_ram_resources and --local_cpu_resources.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=237527805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.