From 50af80511b1f91e39da9f040252571064b4fe796 Mon Sep 17 00:00:00 2001 From: Paul Johnston Date: Sun, 23 May 2021 08:11:22 -0600 Subject: [PATCH 1/5] Update buildifier warnings --- .bazelci/presubmit.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 9c24298c8..006d6ff90 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -1,13 +1,8 @@ --- buildifier: version: 4.0.1 - # Check for issues with the format of our bazel config files. - # All warnings from https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md - # are enabled except: - # rule-impl-return, uninitialized, return-value, rule-impl-return - # TODO (suvanjan): Re-enable once issues are fixed. - warnings: "attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,confusing-name,constant-glob,ctx-actions,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,function-docstring,git-repository,http-archive,integer-division,load,load-on-top,module-docstring,name-conventions,native-build,native-package,no-effect,out-of-order-load,output-group,package-name,package-on-top,redefined-variable,repository-name,same-origin-load,string-iteration,unreachable,unsorted-dict-items,unused-variable" -bazel: 4.0.0 # keep in sync with .bazelversion + warnings: "-rule-impl-return,-uninitialized,-return-value,-rule-impl-return" +bazel: 4.0.0 tasks: default_workspace_ubuntu1804: platform: ubuntu1804 From b4b88b724d42ae3b3e26b976eed4616bbba1a6db Mon Sep 17 00:00:00 2001 From: Paul Johnston Date: Sun, 23 May 2021 08:19:27 -0600 Subject: [PATCH 2/5] Try allow previously excluded --- .bazelci/presubmit.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 006d6ff90..be0a30fba 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -3,6 +3,9 @@ buildifier: version: 4.0.1 warnings: "-rule-impl-return,-uninitialized,-return-value,-rule-impl-return" bazel: 4.0.0 + # Check for issues with the format of our bazel config files. + warnings: "-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" +bazel: 3.5.0 # keep in sync with .bazelversion tasks: default_workspace_ubuntu1804: platform: ubuntu1804 From bcecd69e00e3a11c537c63afd05fac1c619a8e71 Mon Sep 17 00:00:00 2001 From: Paul Johnston Date: Sun, 23 May 2021 08:23:12 -0600 Subject: [PATCH 3/5] Final warning exclusion list --- .bazelci/presubmit.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index be0a30fba..ba7a638a2 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -5,6 +5,8 @@ buildifier: bazel: 4.0.0 # Check for issues with the format of our bazel config files. warnings: "-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" + # List of lint warnings rules_docker does not pass. Good first issue for new contributors. + warnings: "-rule-impl-return,-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" bazel: 3.5.0 # keep in sync with .bazelversion tasks: default_workspace_ubuntu1804: From ab2c23473caae46cc2c778d05b8648c34b22a3cb Mon Sep 17 00:00:00 2001 From: Paul Johnston Date: Sun, 23 May 2021 08:24:44 -0600 Subject: [PATCH 4/5] Missed -return-value --- .bazelci/presubmit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index ba7a638a2..4858a405b 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -6,7 +6,7 @@ bazel: 4.0.0 # Check for issues with the format of our bazel config files. warnings: "-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" # List of lint warnings rules_docker does not pass. Good first issue for new contributors. - warnings: "-rule-impl-return,-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" + warnings: "-rule-impl-return,-return-value,-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" bazel: 3.5.0 # keep in sync with .bazelversion tasks: default_workspace_ubuntu1804: From 6507c8e414636ad20fc7b1a8dcad31dc887eb237 Mon Sep 17 00:00:00 2001 From: Paul Johnston Date: Sun, 23 May 2021 08:50:53 -0600 Subject: [PATCH 5/5] Rebase master --- .bazelci/presubmit.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 4858a405b..705af4a9e 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -1,13 +1,8 @@ --- buildifier: version: 4.0.1 - warnings: "-rule-impl-return,-uninitialized,-return-value,-rule-impl-return" -bazel: 4.0.0 - # Check for issues with the format of our bazel config files. - warnings: "-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" - # List of lint warnings rules_docker does not pass. Good first issue for new contributors. warnings: "-rule-impl-return,-return-value,-function-docstring-args,-print,-skylark-comment,-provider-params,-unnamed-macro" -bazel: 3.5.0 # keep in sync with .bazelversion +bazel: 4.0.0 tasks: default_workspace_ubuntu1804: platform: ubuntu1804