New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use google/protobuf v3.6.0 #1576

Closed
ashi009 opened this Issue Jun 28, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ashi009
Contributor

ashi009 commented Jun 28, 2018

The current version of protobuf includes invalid doc string which is unacceptable by Google Cloud Endpoints config manager:

'ERROR: google/protobuf/timestamp.proto:121:1: (at document line 76) Unexpected end tag '--)' with missing begin tag.'

v3.6.0 provides the fix.

@jayconrod

This comment has been minimized.

Contributor

jayconrod commented Jun 28, 2018

I'll upgrade the proto dependencies soon after #1548 is fixed (which should be in the next couple days). Ideally, I'd like to get a major release out with the fix and upgraded dependencies early next week.

@jayconrod jayconrod added the proto label Jun 28, 2018

@jayconrod

This comment has been minimized.

Contributor

jayconrod commented Jul 9, 2018

master now has v3.6.0.1. That will be in rules_go 0.13.0, which should be released in a day or two.

@jayconrod jayconrod closed this Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment