Export support files needed for using Go's WebAssembly (WASM) output. #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small world, I still remember contributing to Chrome Secure Shell. :-) Thanks for the contribution, I agree this is small enough to just merge. |
fmeum
approved these changes
Aug 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Export support files needed for using Go's WebAssembly (WASM) output. In particular, misc/wasm/wasm_exec.js contains glue code for making use of WASM output within Javascript.
Which issues(s) does this PR fix?
No issue filed. Per contribution guidelines, this looked too minor to file an issue. Please let me know if an issue should be filed.
Other notes for review
Without this change, my project (https://github.com/google/chrome-ssh-agent) needs to apply a patch as part of importing the rules_go repository. This seems general-purpose enough that it should be applied in rules_go itself.