From 18bc6f60c05df758a20bb129b284c48afe6e5544 Mon Sep 17 00:00:00 2001 From: Gibson Fahnestock Date: Wed, 12 Aug 2020 14:27:03 +0100 Subject: [PATCH] Handle tags in java_export rule Using "Tags" attribute on java_export() rule generates java_library(...) got multiple values for parameter 'tags' via java_export rules. --- private/rules/java_export.bzl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/private/rules/java_export.bzl b/private/rules/java_export.bzl index d2c6b23ba..bed048b27 100644 --- a/private/rules/java_export.bzl +++ b/private/rules/java_export.bzl @@ -8,6 +8,7 @@ def java_export( maven_coordinates, pom_template = None, visibility = None, + tags = [], **kwargs): """Extends `java_library` to allow maven artifacts to be uploaded. @@ -56,7 +57,7 @@ def java_export( and so may contain any valid parameter for that rule. """ - tags = getattr(kwargs, "tags", []) + ["maven_coordinates=%s" % maven_coordinates] + tags = tags + ["maven_coordinates=%s" % maven_coordinates] lib_name = "%s-lib" % name # Construct the java_library we'll export from here.