Kotlin 1.4

[fkorotkov]

Just bumped all the version. Seems there were not much changes on the compiler side since 1.3.x beside adding new language features and removing deprecating stdlib methods. Should be pretty painless update.

Fixes #295

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[fkorotkov]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[restingbull]

Brief pause on this -- I'm seeing some oddities where using 1.3 is getting 1.4 libraries without changing the default version.

[fkorotkov]

@restingbull if oddities are hard to investigate, alternatively we can keep the 1.3 default and just allow 1.4 language version with a custom toolchain.

[rockwotj]

@restingbull if oddities are hard to investigate, alternatively we can keep the 1.3 default and just allow 1.4 language version with a custom toolchain.

I'd really love to move forward with 1.4 - can we do this and document the 1.4 custom toolchain? I think a separate change could make it the default...

/cc @restingbull @cgruber @fkorotkov

[cgruber]

If I understand comments from @restingbull - this can't work as-is, as there are some issues with hand-crafted classpaths in the builder that need fixing. I believe he's going to take a crack at it shortly, but we've been on-deadline internally, and haven't had the time to take care of this.

We absolutely do need 1.4 support ourselves, and soon, so this will get done.

[cgruber]

I've merged this, as despite us having some theoretical misgivings that we're missing something, we're just not moving forward fast enough. So this way the community is freed up to detect it.

[rockwotj]

Thanks @cgruber should we wait for a release or just point something to master?

[cgruber]

You can point to master if you want, but I plan to release in a day or two. There are one or two last little fixes i would like to get in together, but if they take more than tomorrow I'll roll a release on Friday. Nothing ever stops you from pointing to a specific commit though.

That said, please remember that if you point at master, and not from a release binary, you'll need to do the extra developer setup, so you can build all the tooling itself. The release package will have all pre-built binaries.

[rockwotj]

@cgruber I finally got around to testing this with my company's codebase and 1.4 works beautifully. We're planning a release tomorrow using master.

Is there a reason https://github.com/bazelbuild/rules_kotlin/releases/tag/legacy-1.4.0-rc4 didn't include this PR? (see here for example)