Stop stripping tree artifact root name in pkg_tar and pkg_zip. #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes bazelbuild#404 While adding tests to make sure we actually could strip it with pkg_files, I discovered a deficiency in pkg_tar_test. It was not doing a check on the file names, only content and type. Fixing that exposed a pre-existing bug. Fortunately, the problem uncovered is fixed by bazelbuild#554, so the tests should pass once that, followed by this PR are submitted. Allow pkg_files.strip_prefix to work on tree artifact without having to use `renames`. Update to 0.7.0 to reflect that this is sort of a big behavioral change.
jylinv0
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #404
While adding tests to make sure we actually could strip it with
pkg_files, I discovered a deficiency in pkg_tar_test. It was not doing
a check on the file names, only content and type. Fixing that exposed
a pre-existing bug.
Fortunately, the problem uncovered is fixed by #554, so the tests
should pass once that, followed by this PR are submitted.
Allow pkg_files.strip_prefix to work on tree artifact without having to
use
renames.Update to 0.7.0 to reflect that this is sort of a big behavioral change.