From 129605ec73632f5ffbac461cdf229b441ef7d32f Mon Sep 17 00:00:00 2001 From: UebelAndre Date: Wed, 17 Feb 2021 11:59:46 -0800 Subject: [PATCH] Updated min tested version to 3.5.0 and improved some vernacular (#586) * Updated some vernacular * Updated min version to 4.0.0 * Addressed PR feedback * Lowered min tested version to 3.5.0 --- .bazelci/presubmit.yml | 2 +- docs/index.md | 5 ++++- rust/platform/BUILD | 2 +- tools/allowlists/function_transition_allowlist/BUILD | 4 ++++ tools/whitelists/function_transition_whitelist/BUILD | 4 ---- wasm_bindgen/wasm_bindgen.bzl | 4 ++-- 6 files changed, 12 insertions(+), 9 deletions(-) create mode 100644 tools/allowlists/function_transition_allowlist/BUILD delete mode 100644 tools/whitelists/function_transition_whitelist/BUILD diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index d1f8c8a5c6..355cd59c22 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -20,7 +20,7 @@ tasks: - "//test/versioned_dylib:versioned_dylib_test" ubuntu2004: name: "Minimum Supported Version" - bazel: "3.0.0" + bazel: "3.5.0" build_targets: *default_linux_targets test_targets: *default_linux_targets macos: diff --git a/docs/index.md b/docs/index.md index 65cbb5350e..3c6cc26d34 100644 --- a/docs/index.md +++ b/docs/index.md @@ -32,7 +32,10 @@ load("@rules_rust//rust:repositories.bzl", "rust_repositories") rust_repositories() ``` -The rules are under active development, as such the lastest commit on the master branch should be used. `master` currently requires Bazel >= 3.0.0. +The rules are under active development, as such the lastest commit on the +`main` branch should be used. `main` is only tested against `4.0.0` as the +minimum supported version of Bazel. Though previous versions may still be +supported in certain environments. ## Rules diff --git a/rust/platform/BUILD b/rust/platform/BUILD index 5dfb9459f7..1b90cee1ef 100644 --- a/rust/platform/BUILD +++ b/rust/platform/BUILD @@ -6,7 +6,7 @@ package(default_visibility = ["//visibility:public"]) declare_config_settings() package_group( - name = "function_transition_whitelist", + name = "function_transition_allowlist", packages = [ "//...", ], diff --git a/tools/allowlists/function_transition_allowlist/BUILD b/tools/allowlists/function_transition_allowlist/BUILD new file mode 100644 index 0000000000..9fdee4b1f6 --- /dev/null +++ b/tools/allowlists/function_transition_allowlist/BUILD @@ -0,0 +1,4 @@ +package_group( + name = "function_transition_allowlist", + packages = ["//..."], +) diff --git a/tools/whitelists/function_transition_whitelist/BUILD b/tools/whitelists/function_transition_whitelist/BUILD deleted file mode 100644 index ce5c613612..0000000000 --- a/tools/whitelists/function_transition_whitelist/BUILD +++ /dev/null @@ -1,4 +0,0 @@ -package_group( - name = "function_transition_whitelist", - packages = ["//..."], -) diff --git a/wasm_bindgen/wasm_bindgen.bzl b/wasm_bindgen/wasm_bindgen.bzl index 4d64094029..477e0cccbc 100644 --- a/wasm_bindgen/wasm_bindgen.bzl +++ b/wasm_bindgen/wasm_bindgen.bzl @@ -148,8 +148,8 @@ rust_wasm_bindgen = rule( allow_single_file = True, cfg = wasm_bindgen_transition, ), - "_whitelist_function_transition": attr.label( - default = Label("//tools/whitelists/function_transition_whitelist"), + "_allowlist_function_transition": attr.label( + default = Label("//tools/allowlists/function_transition_allowlist"), ), }, outputs = {