From bbd26b9be2951f75ae0112be5d4dc74f4324aee6 Mon Sep 17 00:00:00 2001 From: Augie Fackler Date: Thu, 7 Apr 2022 17:32:07 -0400 Subject: [PATCH] rust_test_suite: ensure crate names are valid I noticed this while setting up rust_test_suite auto-generation at work. Seems like a simple enough fix. --- rust/private/rust.bzl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rust/private/rust.bzl b/rust/private/rust.bzl index af11c9fe1f..dfef5c88cf 100644 --- a/rust/private/rust.bzl +++ b/rust/private/rust.bzl @@ -23,6 +23,7 @@ load( "expand_dict_value_locations", "find_toolchain", "get_import_macro_deps", + "name_to_crate_name", "transform_deps", ) @@ -1179,7 +1180,7 @@ def rust_test_suite(name, srcs, **kwargs): test_name = name + "_" + src[:-3] rust_test( name = test_name, - crate_name = test_name.replace("/", "_"), + crate_name = name_to_crate_name(test_name.replace("/", "_")), srcs = [src], **kwargs )