From 8741efc19cefad9db1540f09b238e85bac0303ea Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Tue, 26 Apr 2022 14:24:09 -0700 Subject: [PATCH] rustc: fix a conditional `("bar" or "baz")` always evaluates to "bar", so this conditional ignores `"dylib"`. This seems unintended. --- rust/private/rustc.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/private/rustc.bzl b/rust/private/rustc.bzl index 49f742ff1d..2055f25f0c 100644 --- a/rust/private/rustc.bzl +++ b/rust/private/rustc.bzl @@ -119,7 +119,7 @@ def _are_linkstamps_supported(feature_configuration, has_grep_includes): has_grep_includes) def _should_use_pic(cc_toolchain, feature_configuration, crate_type): - if crate_type in ("cdylib" or "dylib"): + if crate_type in ("cdylib", "dylib"): return cc_toolchain.needs_pic_for_dynamic_libraries(feature_configuration = feature_configuration) return False