Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear docs about output name #99

Closed
jathak opened this issue Oct 11, 2019 · 1 comment · Fixed by #100
Closed

Unclear docs about output name #99

jathak opened this issue Oct 11, 2019 · 1 comment · Fixed by #100

Comments

@jathak
Copy link
Contributor

jathak commented Oct 11, 2019 •
edited

In the docs for sass_binary, the implicit output targets are listed as name.css and name.css.map, but the actual default output_name is based on the src of the rule, not the name.
@nex3
Copy link
Collaborator

nex3 commented Oct 11, 2019

@jathak Want to submit a PR for this?

jathak added a commit to jathak/rules_sass that referenced this issue Oct 11, 2019
@jathak
Clarify outputs of sass_binary
36a2832 
Fix bazelbuild#99.
@jathak jathak mentioned this issue Oct 11, 2019
Merged
@nex3 nex3 closed this as completed in #100 Oct 11, 2019
nex3 pushed a commit that referenced this issue Oct 11, 2019
@jathak @nex3
Clarify outputs of sass_binary (#100)
e6a3a07 
Fix #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify outputs of sass_binary jathak/rules_sass
2 participants
@nex3 @jathak