Get triple from the make variable CC_TARGET_TRIPLE #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma-oli
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
keith
reviewed
Aug 15, 2025
Allow overriding the target triple used by the Xcode Swift toolchain through the CC_TARGET_TRIPLE environment variable. As cc_toolchain.target_gnu_system_name is getting deprecated, and as rules based toolchain currently don't offer the option to set it anymore, this offers a way by which someone can define a rules based toolchain and still have working swift rules.
ma-oli
force-pushed
the
use-triple-from-var
branch
from
3915eb9 to
6a53d38
Compare
Contributor
Author
|
Done ✅ |
keith
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding the target triple used by the Xcode Swift toolchain through the CC_TARGET_TRIPLE environment variable. As cc_toolchain.target_gnu_system_name is getting deprecated, and as rules based toolchain currently don't offer the option to set it anymore, this offers a way by which someone can define a rules based toolchain and still have working swift rules.