Unconditionally pass -file-prefix-map to the compiler to remove nondeterministic paths. #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
referenced
this pull request
Sep 26, 2025
…deterministic paths. Simplified the `debug_settings` tests since the rules unconditionally pass `-file-prefix-map` now. We may want to remove the support for `-debug-prefix-map` in the future since it's redundant. PiperOrigin-RevId: 794552613
luispadron
force-pushed
the
luis/cp-038b5bd7
branch
from
1b854ab to
ca5e1a2
Compare
luispadron
force-pushed
the
luis/cp-a440c7ebbc5a0a30a
branch
from
18b7df4 to
e0161f9
Compare
luispadron
requested review from
aaronsky,
brentleyjones,
keith and
mattrobmattrob
as code owners
Contributor
Author
|
Need to rebase this. Only the second commit is relevant |
brentleyjones
approved these changes
Sep 26, 2025
…terministic paths. Simplified the `debug_settings` tests since the rules unconditionally pass `-file-prefix-map` now. We may want to remove the support for `-debug-prefix-map` in the future since it's redundant. Cherry-pick: a440c7e
luispadron
force-pushed
the
luis/cp-a440c7ebbc5a0a30a
branch
from
e0161f9 to
28d9174
Compare
Contributor
Author
|
@brentleyjones This can merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the
debug_settingstests since the rules unconditionally pass-file-prefix-mapnow. We may want to remove the support for-debug-prefix-mapin the future since it's redundant.Cherry-pick: a440c7e