Sort headers in the module maps generated by swift_clang_module_aspect, and rewrite generation to use a multi-line Args object as a file writer instead of building up an analysis time string.
#596
Conversation
…ct`, and rewrite generation to use a multi-line `Args` object as a file writer instead of building up an analysis time string. With this approach, each "arg" (or each entry in a list/depset of args) is treated as its own line in the output file; we use the `format_each` and `map_each` parameters to provide any additional text that should surround that value on the line. More importantly, this adds support for expanding tree artifacts (directories) if one is provided in a compilation context. PiperOrigin-RevId: 367221120
|
ha seems like nested functions are a newer feature than what is currently released in bazel |
|
Maybe it's worth requesting the change for that feature to be cherry-picked into 4.1, if it's not in there yet. |
…ct`, and rewrite generation to use a multi-line `Args` object as a file writer instead of building up an analysis time string. With this approach, each "arg" (or each entry in a list/depset of args) is treated as its own line in the output file; we use the `format_each` and `map_each` parameters to provide any additional text that should surround that value on the line. More importantly, this adds support for expanding tree artifacts (directories) if one is provided in a compilation context. PiperOrigin-RevId: 367221120 (cherry picked from commit 5f7af69)
keith
force-pushed
the
ks/sort-headers-in-the-module-maps-generated-by-swift_clang_module_aspect-and-rewrite-generation-to-use-a-multi-line-args-object-as-a-file-writer-instead-of-building-up-an-analysis-time-string
branch
from
b8f1c04
to
ecb5148
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
keith
deleted the
ks/sort-headers-in-the-module-maps-generated-by-swift_clang_module_aspect-and-rewrite-generation-to-use-a-multi-line-args-object-as-a-file-writer-instead-of-building-up-an-analysis-time-string
branch
With this approach, each "arg" (or each entry in a list/depset of args) is treated as its own line in the output file; we use the
format_eachandmap_eachparameters to provide any additional text that should surround that value on the line.More importantly, this adds support for expanding tree artifacts (directories) if one is provided in a compilation context.
PiperOrigin-RevId: 367221120
(cherry picked from commit 5f7af69)