Improving Readabililty #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 17, 2023 16:04
removed unused imports remove unused commented code
add agg_by_min_or_max to replace agg_by_min & agg_by_max add aggregate_strings to replace agg_by_jag_word & agg_by_jag_char remove unused imports
shopdrop1
approved these changes
Jul 17, 2023
|
Hi @zbloss, thanks a lot! I fixed a few conflicts and it's merged now. Yes, I agree there is a lot to improve! Just invited you to collaborate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First great work on this project!
This PR mainly improves the readability of the project via type-hinting, docstrings, and in some cases changing variable names or combining functions. I need @bazingagin to verify that nothing here is truly broken, though it's working on my end.
There are still opportunities to improve here and I'm happy to partner up if the appetite is here.