Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to NativeScript 6, and lazily get the Android Vibrator service #85

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

EddyVerbruggen
Copy link
Contributor

Hi!

I wanted to be able to create the Vibrator class on Android before there was a context available, and that crashed my app.

This change supports that case, so making it more robust for silly folks like me using it in unintended ways.

Also: bump to NativeScript 6.

Thanks,
Eddy

@ghost
Copy link

ghost commented Oct 27, 2019

There were the following issues with this Pull Request

  • Commit: e6dc2ce
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Oct 27, 2019

There were the following issues with this Pull Request

  • Commit: e6dc2ce
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: d16c204
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@stale
Copy link

stale bot commented Nov 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 10, 2019
@EddyVerbruggen
Copy link
Contributor Author

It would be nice if this would not be auto-closed by a bot ;)

@stale stale bot removed the wontfix label Nov 10, 2019
@juliomrqz juliomrqz merged commit 0291aac into juliomrqz:develop Nov 13, 2019
@juliomrqz
Copy link
Owner

juliomrqz commented Nov 13, 2019

Hello, @EddyVerbruggen. Thanks for your contribution 🤓 This week a new version will be released.

@juliomrqz
Copy link
Owner

Hello, @EddyVerbruggen. You contribution is now available in the latest version (v3.0.0) 😀

@EddyVerbruggen
Copy link
Contributor Author

@juliomrqz Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants