lettuce_webdriver throws exception with a recent selenium version #18

Merged
merged 1 commit into from Nov 19, 2012

Conversation

Projects
None yet
2 participants
@arnihermann
Contributor

arnihermann commented Nov 19, 2012

It's incompatible with recent selenium versions: a text_field == False comparison tries to look up the id property of the boolean.

The patch includes a simple fix and a version bump.

Fix the guard from 0.2.
It's incompatible with recent selenium versions.
@npilon

This comment has been minimized.

Show comment Hide comment
@npilon

npilon Nov 19, 2012

Collaborator

Looks reasonable.

Collaborator

npilon commented Nov 19, 2012

Looks reasonable.

npilon added a commit that referenced this pull request Nov 19, 2012

Merge pull request #18 from arnihermann/master
lettuce_webdriver throws exception with a recent selenium version

@npilon npilon merged commit 708e8f0 into bbangert:master Nov 19, 2012

@arnihermann

This comment has been minimized.

Show comment Hide comment
@arnihermann

arnihermann Nov 19, 2012

Contributor

Thanks for the quick response.

Will you publish the change to pypi?

Contributor

arnihermann commented Nov 19, 2012

Thanks for the quick response.

Will you publish the change to pypi?

@arnihermann

This comment has been minimized.

Show comment Hide comment
@arnihermann

arnihermann Dec 4, 2012

Contributor

@npilon Could you publish a new version to the python package index?

Contributor

arnihermann commented Dec 4, 2012

@npilon Could you publish a new version to the python package index?

@npilon

This comment has been minimized.

Show comment Hide comment
@npilon

npilon Dec 4, 2012

Collaborator

Sorry, I meant to do that last week and got completely swamped. Should be up now, thank you for your patience!

Collaborator

npilon commented Dec 4, 2012

Sorry, I meant to do that last week and got completely swamped. Should be up now, thank you for your patience!

@arnihermann

This comment has been minimized.

Show comment Hide comment
@arnihermann

arnihermann Dec 4, 2012

Contributor

No problem, thanks!

Contributor

arnihermann commented Dec 4, 2012

No problem, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment