New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox.ini #55

Merged
merged 1 commit into from Feb 15, 2016

Conversation

Projects
None yet
2 participants
@vstinner
Contributor

vstinner commented Nov 27, 2015

tox is a nice tool to run tests: it creates virtual environments,
install test dependencies and run tests. With the simple command
"tox", tests are run on Python 2 and Python 3.

Tests are run using nosetests. Test dependencies are: coverage, nose,
webob and webtest.

@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Nov 27, 2015

Contributor

I failed to find any documentation on tests, so I don't know where is the best place to document the tox command to run tests.

I don't know what is your favorite test runner, so I picked nose. I don't really care of the test runner, I only care of having a simple command to run all tests.

Contributor

vstinner commented Nov 27, 2015

I failed to find any documentation on tests, so I don't know where is the best place to document the tox command to run tests.

I don't know what is your favorite test runner, so I picked nose. I don't really care of the test runner, I only care of having a simple command to run all tests.

@bbangert

This comment has been minimized.

Show comment
Hide comment
@bbangert

bbangert Jan 13, 2016

Owner

The tests are run via travis, so changing the .travis.yml file to run the tox command would work for this PR, that way the working change can be verified and used going forward.

Owner

bbangert commented Jan 13, 2016

The tests are run via travis, so changing the .travis.yml file to run the tox command would work for this PR, that way the working change can be verified and used going forward.

@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Feb 9, 2016

Contributor

The tests are run via travis, so changing the .travis.yml file to run the tox command would work for this PR, that way the working change can be verified and used going forward.

Ok: I found https://github.com/ryanhiebert/tox-travis which can help here. See my updated pull request.

Contributor

vstinner commented Feb 9, 2016

The tests are run via travis, so changing the .travis.yml file to run the tox command would work for this PR, that way the working change can be verified and used going forward.

Ok: I found https://github.com/ryanhiebert/tox-travis which can help here. See my updated pull request.

@bbangert

This comment has been minimized.

Show comment
Hide comment
@bbangert

bbangert Feb 13, 2016

Owner

Seems a rebase is needed now.

Owner

bbangert commented Feb 13, 2016

Seems a rebase is needed now.

Add tox.ini
tox is a nice tool to run tests: it creates virtual environments,
install test dependencies and run tests. With the simple command
"tox", tests are run on Python 2 and Python 3.

* Create tox.ini based on .travis.yml
* Modidy .travis.yml to use tox-travis:
  https://github.com/ryanhiebert/tox-travis
* .gitignore: ignore .tox/ sub-directory created by tox.
@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Feb 15, 2016

Contributor

Seems a rebase is needed now.

Done. I added to add a special case for Python 2.6, since Python 2.6 doesn't support "python2.6 -m nose ..." command.

(In 2016, it's maybe time to deprecate or drop Python 2.6 suppor ;-))

Contributor

vstinner commented Feb 15, 2016

Seems a rebase is needed now.

Done. I added to add a special case for Python 2.6, since Python 2.6 doesn't support "python2.6 -m nose ..." command.

(In 2016, it's maybe time to deprecate or drop Python 2.6 suppor ;-))

bbangert added a commit that referenced this pull request Feb 15, 2016

@bbangert bbangert merged commit ae9b86a into bbangert:master Feb 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vstinner vstinner deleted the vstinner:tox branch Feb 15, 2016

@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Feb 15, 2016

Contributor

Great :-) Would you mind to release a new version to benefit of the bugfix #56?

Contributor

vstinner commented Feb 15, 2016

Great :-) Would you mind to release a new version to benefit of the bugfix #56?

@bbangert

This comment has been minimized.

Show comment
Hide comment
@bbangert

bbangert Feb 29, 2016

Owner

Sure, there's been quite a few additions as well that have gone in.

Owner

bbangert commented Feb 29, 2016

Sure, there's been quite a few additions as well that have gone in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment