Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to disregard parent's bottom padding when calculating its offset? #23

Closed
artemgordinskiy opened this issue May 21, 2015 · 6 comments · Fixed by #24
Closed

Comments

@artemgordinskiy
Copy link
Contributor

Hi,
First of all, great job on the plugin, thank you!

I hope to find a way to have an element stay fixed until the absolute bottom of the parent, with no regard for its bottom padding. I encountered an issue with this line, specifically:

this._parentBottom = (this.parent.offsetHeight + this._fullOffset('offsetTop', this.parent)) - computedStyle.getFloat(this.parent, 'paddingBottom');

When I remove the last subtraction, it works perfectly for my use case. Maybe this could be added as an option? If so, I'd be happy to contribute.

@bbarakaci
Copy link
Owner

Hi, Thank you.
Currently there is no way to ignore padding.
Yes, why not, i think it is good to have it as an option.

@artemgordinskiy
Copy link
Contributor Author

Okay, but how do I build it? I see a Grunt file but no package.json in there.

@bbarakaci
Copy link
Owner

I used to increase the version in the gruntfile and run grunt make

It will be also ok if you just commit the feature and optionally document the option on readme. I could take care of building and releasing the new version.

artemgordinskiy added a commit to artemgordinskiy/fixto that referenced this issue May 24, 2015
@artemgordinskiy
Copy link
Contributor Author

I hope I didn't screw anything up.
Also, tried to run grunt make, but got "Fatal error: Unable to find Gruntfile.", so I wasn't able to build the project, sorry.

@bbarakaci
Copy link
Owner

Excuse me for the delay, i couldn't find the time.

Maybe it is because the grunt version is quite old.

Thank you. Cheers.

@artemgordinskiy
Copy link
Contributor Author

No problem, it's open source after all, nobody owes anything to anyone 😄
Thanks for accepting the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants