New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignored-*-p: Match against regular expressions #1260

Merged
merged 9 commits into from Jul 28, 2018

Conversation

Projects
None yet
2 participants
@shackra
Contributor

shackra commented Jul 27, 2018

Buffers are created by other packages that appear on projectile's buffer lists, but they always have
some variation that makes impossible including all possible name cases, thus regular expressions
come handy for this sort of cases. This commit allows *-ignored-*-p functions to work with regular
expressions.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

shackra added some commits Sep 19, 2017

ignored-*-p: Match regular expressions with strings
Buffers are created by other packages that appear on projectile's buffer lists, but they always have
some variation that makes impossible including all possible name cases, thus regular expressions
come handy for this sort of cases. This commit allows `*-ignored-*-p` functions to work with regular
expressions.
Call function instead of using variable
The function was incorrectly defined, causing to fail on tests. The correct thing to do is to call
`projectile-ignored-directories` which returns a sequence.
Update CHANGELOG with correct pull request ID
A new one has to be created as I mess with my fork and the branch
@shackra

This comment has been minimized.

Show comment
Hide comment
@shackra

shackra Jul 27, 2018

Contributor

@bbatsov I have done all the fixes as you requested from the pull request #1177 I had to close that one because, boy, I'm really bad at Git.

Tell me what you think and please don't let this one be forgotten too :P

Contributor

shackra commented Jul 27, 2018

@bbatsov I have done all the fixes as you requested from the pull request #1177 I had to close that one because, boy, I'm really bad at Git.

Tell me what you think and please don't let this one be forgotten too :P

@bbatsov bbatsov merged commit d2b808b into bbatsov:master Jul 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shackra shackra deleted the shackra:ignored-p-regexp branch Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment