Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow completions for projectile-run{-async,}-shell-command-in-root #1716

Merged
merged 2 commits into from Nov 1, 2021
Merged

Allow completions for projectile-run{-async,}-shell-command-in-root #1716

merged 2 commits into from Nov 1, 2021

Conversation

daanturo
Copy link
Contributor

@daanturo daanturo commented Oct 31, 2021 •
edited

By using read-shell-command.

Fixes #1692 .

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

@daanturo
Allow completions for *shell-command-in-root
794fb77 
By using `read-shell-command`.
daanturo added a commit to daanturo/projectile that referenced this pull request Oct 31, 2021
@daanturo
Update README for bbatsov#1716
fff079a
@daanturo daanturo force-pushed the completions-for-shell-command branch from fff079a to ec11b51 Compare October 31, 2021 16:56
@bbatsov bbatsov merged commit e5ccfdd into bbatsov:master Nov 1, 2021
@bbatsov
Copy link
Owner

bbatsov commented Nov 1, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab-completion in projectile-run-shell-command-in-root
2 participants
@daanturo @bbatsov