|| / or #19

Closed
pointlessone opened this Issue Oct 23, 2011 · 1 comment

Projects

None yet

2 participants

@pointlessone
Contributor

CarrierWave initializer contains line:

if Rails.env.development? or Rails.env.production?

Use &&/|| for boolean expressions, and/or for control flow.
-- Ruby style guide

I assume, Rails style guide is build on top of Ruby style guide. So lets be consistent and use double pipe operator for booleans.

@bbatsov
Owner
bbatsov commented Oct 23, 2011

It most certainly is :-) I'll correct that.

@bbatsov bbatsov added a commit that closed this issue Oct 23, 2011
@bbatsov fixes #19 d8664ab
@bbatsov bbatsov closed this in d8664ab Oct 23, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment