Skip to content

Loading…

subscriptions#unsubscribe should be shown as a member route. #8

Merged
merged 1 commit into from

2 participants

@jclem

To avoid confusion, subscriptions#unsubscribe should be a member route, not a collection route here, i.e.

# bad
get 'subscriptions/:id/unsubscribe'
resources :subscriptions

instead of:

# bad
get 'subscriptions/unsubscribe' # this would be a collection route
resources :subscriptions
@bbatsov bbatsov merged commit 86a35a9 into bbatsov:master
@bbatsov
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 21, 2011
  1. To avoid confusion, subscriptions#unsubscribe should be a member rout…

    Jonathan Clem committed
    …e, not a collection route here.
Showing with 2 additions and 2 deletions.
  1. +2 −2 README.md
View
4 README.md
@@ -92,8 +92,8 @@ configuration needs to be applied in the
```Ruby
# bad
- get 'subscriptions/unsubscribe'
- resources 'subscription'
+ get 'subscriptions/:id/unsubscribe'
+ resources :subscriptions
# good
resources :subscriptions do
Something went wrong with that request. Please try again.