Support Rainbow gem both 1.99.x and 2.x #763

Merged
merged 1 commit into from Jan 25, 2014

Projects

None yet

4 participants

@yujinakayama
Collaborator

This fixes #762.

Owner
bbatsov commented Jan 25, 2014

Hmm, does it really make sense to support 1.99.x now that 2.0 is out? I guess the majority of users run into gem conflict problems because they put RuboCop in their Gemfiles, which they shouldn't do IMO.

jhx commented Jan 25, 2014

I would tend to support both 1.99.x and 2.x rainbow gem versions unless there is a compelling reason to drop support for the old one (e.g. major incompatibility). It seems the differences between the two versions are fairly minor in this case.

FYI, I put RuboCop into my Gemfile so Travis-CI will load it and execute the rake tasks (knife checks, rubocop lint, foodcritic lint, etc.). I could probably work around this by creating a separate Gemfile and tell Travis-CI to use this; this seems to be more complicated than necessary and doesn't feel very DRY.

My main barrier to using the latest version of RuboCop is the gem dependency conflict with chef and json.

@bbatsov bbatsov merged commit bfdada4 into bbatsov:master Jan 25, 2014

1 check passed

default The Travis CI build passed
Details
Owner
bbatsov commented Jan 25, 2014

@jhx Fair enough. Can't you use the chef from master?

Collaborator

IMO, if a project forces its team to use RuboCop, RuboCop should be added to the Gemfile or *.gemspec as a development dependency like we do the same for testing frameworks.

@yujinakayama yujinakayama deleted the unknown repository branch Jan 25, 2014
@dblock dblock added a commit to ruby-grape/grape-entity that referenced this pull request Jan 28, 2014
@dblock dblock Workaround for Rainbow dependency, see bbatsov/rubocop#763. 41d3ba1
@dblock dblock added a commit to ruby-grape/grape that referenced this pull request Jan 28, 2014
@dblock dblock Workaround for Rainbow dependency, see bbatsov/rubocop#763. ebd60d4
Contributor
dblock commented Jan 28, 2014

You should release a version with this fix, just cause Rubocop 0.17.0 breaks out of the box.

Owner
bbatsov commented Jan 28, 2014

I'm aware of that. I'll probably update the gem later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment