Skip to content
Browse files

Change paren match faces

Changed to having just magenta as foreground.

- Magenta is the main temporary highlight face of this theme.
- Solves issue with inverse-video and regions.
  • Loading branch information...
1 parent 84bf758 commit 3de9aca0a8b1cdd2cf7a5c58829b3f14520e76b7 @thomasf thomasf committed
Showing with 14 additions and 14 deletions.
  1. +14 −14 solarized.el
View
28 solarized.el
@@ -1319,30 +1319,30 @@ customize the resulting theme."
`(sp-wrap-tag-overlay-face ((,class (:background ,base02))))
`(sp-show-pair-enclosing ((,class (:inherit highlight))))
`(sp-show-pair-match-face
- ((,class (:foreground ,cyan :background ,base03
- :weight normal :inverse-video t))))
+ ((,class (:background unspecified :foreground ,magenta
+ :weight normal))))
@vspinu
vspinu added a note

This change plays badly with rainbow-delimiter mode. Magenta is not quite distinguishable from the red face. Could you please make it "bold"? Thanks.

invisible_paren_match

@thomasf Collaborator
thomasf added a note

Maybe.. How about removing red from rainbow-delimiters instead? I would generally like red not to be seen at all unless it is signaling an error of some kind.

edit: its not even there now, its orange only.. red and orange also looks almost exactly the same too often.
That would leave only cyan, yellow, blue, green.. Maybe its worth trying to replace orange with violet instead if that does not look to similar to something else.

@vspinu
vspinu added a note

I also don't quite like orange in rainbow delimiters. I tried violet instead and
it is much better indeed. I really like it.

I would still like to have the "bold" for the matching parents because it is
much easier to detect the change with the peripheral vision. When bold or
inverse video, my brain kind of detects the matching pair without even looking
explicitly at it. With the current setup there is no enough change and I am
finding myself always searching for the matching parent explicitly. Kind of
tiresome and annoying.

@thomasf Collaborator
thomasf added a note

I see, I will make both changes then. (while keeping non bold in my personal config). . Visibility differences can be very large depending on both os and fonts used.

My reason for making it non bold in the first place is to not draw the attention away from current point, I also feel like the 1-2 characters surrounding the bolded paren becomes a little harder to read.

@vspinu
vspinu added a note

Hi again. All this time I have been trying violet instead of orange for rainbow-delimiters and now I am reverting that. It is really much harder to locate delimiters right now. The colors are too monotone.

The orange delimiter was kind of a reference parenthesis.

@thomasf Collaborator
thomasf added a note

btw. I find it much easier on the mind/eyes with only using pair highlitning + parenface with comment style parens everywhere or using the newish rainbow blocks mode because non of those produces color mess of rainbow delimiters do. When you also can have paredit or smartparens-strict-mode or a similar mode acticated with their improved navigation and manipulation features the need for highlighting anything but the current context is very rare.

@thomasf Collaborator
thomasf added a note

that said, languages that uses delimiters less often will work better with rainbow delimiters and not producing the infernal color mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
`(sp-show-pair-mismatch-face
- ((,class (:foreground ,red :background ,base03
- :weight normal :inverse-video t))))
+ ((,class (:foreground ,base02 :background ,red
+ :weight normal))))
;; show-paren
`(show-paren-match
- ((,class (:foreground ,cyan :background ,base03
- :weight normal :inverse-video t))))
+ ((,class (:foreground ,magenta :background unspecified
+ :weight normal))))
`(show-paren-mismatch
- ((,class (:foreground ,red :background ,base03
- :weight normal :inverse-video t))))
+ ((,class (:foreground ,base02 :background ,red
+ :weight normal))))
;; mic-paren
`(paren-face-match
- ((,class (:foreground ,cyan :background ,base03
- :weight normal :inverse-video t))))
+ ((,class (:foreground ,magenta :background unspecified
+ :weight normal))))
`(paren-face-mismatch
- ((,class (:foreground ,red :background ,base03
- :weight normal :inverse-video t))))
+ ((,class (:foreground ,base02 :background ,red
+ :weight normal))))
`(paren-face-no-match
- ((,class (:foreground ,red :background ,base03
- :weight normal :inverse-video t))))
+ ((,class (:foreground ,base02 :background ,red
+ :weight normal))))
;; SLIME
`(slime-repl-inputed-output-face ((,class (:foreground ,red))))

0 comments on commit 3de9aca

Please sign in to comment.
Something went wrong with that request. Please try again.