Skip to content

Commit

Permalink
make paren matching faces bold
Browse files Browse the repository at this point in the history 
requested here: 3de9aca#commitcomment-5460889
  • Loading branch information
@thomasf
thomasf committed Feb 23, 2014
1 parent 2edd55d commit 86fd9b8
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions solarized.el
View file
Expand Up @@ -1307,18 +1307,18 @@ customize the resulting theme."
`(sp-show-pair-enclosing ((,class (:inherit highlight))))
`(sp-show-pair-match-face
((,class (:background unspecified :foreground ,magenta
:weight unspecified))))
:weight bold))))
`(sp-show-pair-mismatch-face
((,class (:foreground ,base02 :background ,red
:weight unspecified))))
:weight bold))))

;; show-paren
`(show-paren-match
((,class (:foreground ,magenta :background unspecified
:weight unspecified))))
:weight bold))))
`(show-paren-mismatch
((,class (:foreground ,base02 :background ,red
:weight unspecified))))
:weight bold))))

;; syslog-mode
`(syslog-ip ((,class (:background unspecified
Expand Down Expand Up @@ -1347,13 +1347,13 @@ customize the resulting theme."
;; mic-paren
`(paren-face-match
((,class (:foreground ,magenta :background unspecified
:weight unspecified))))
:weight bold))))
`(paren-face-mismatch
((,class (:foreground ,base02 :background ,red
:weight unspecified))))
:weight bold))))
`(paren-face-no-match
((,class (:foreground ,base02 :background ,red
:weight unspecified))))
:weight bold))))

;; SLIME
`(slime-repl-inputed-output-face ((,class (:foreground ,red))))
Expand Down

6 comments on commit 86fd9b8

@bradwright
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this not be an option? Are you sure everyone wants bold paren matching faces?

@oscarfv
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it is worth mentioning that several popular fonts lack bold/italic variants. Other fonts (like Consolas, that I use) show little difference among bold/normal parens. And some text terminals cannot display bold/italic at all.

So IMHO this effect is nice to have, but we shouldn't rely too much on it for making text more visible than its surroundings.

@thomasf
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not use this Bolding. I have removed that and more in my personal child theme, might not have pushed that particular change to (https://github.com/thomasf/dotfiles-thomasf-emacs/blob/master/emacs.d/lisp/my-solarized.el). My general advice for making the solarized accent colors easy to distinguish would be to increase the font size but that is not always practical for everyone. Also, everything is optional (hello elisp).

@thomasf
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I eventually want to have is a couple of high level profiles that mostly set the intensity level of visual cues.

@thomasf
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscarfv: Consolas is a really awesome font, ihmo it is a very good decision for a programming font to bold parens only slightly. I looked through bolded parens of 5-10 fonts before removing them from the match faces, a lot of very suitable programming fonts puts too much bold on parens.

@thomasf
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a custom option called solarized-use-less-bold that also removes bold from font-lock-builtin-face which is what I have been using for a very long while.. I also added an solarized-use-more-italic for those of us that uses fonts which have a good looking italic slant.

Please sign in to comment.