Permalink
Browse files

make paren matching faces bold

  • Loading branch information...
thomasf committed Feb 23, 2014
1 parent 2edd55d commit 86fd9b8312d80762b1735c91298cc161589b7a57
Showing with 7 additions and 7 deletions.
  1. +7 −7 solarized.el
View
@@ -1307,18 +1307,18 @@ customize the resulting theme."
`(sp-show-pair-enclosing ((,class (:inherit highlight))))
`(sp-show-pair-match-face
((,class (:background unspecified :foreground ,magenta
- :weight unspecified))))
+ :weight bold))))
`(sp-show-pair-mismatch-face
((,class (:foreground ,base02 :background ,red
- :weight unspecified))))
+ :weight bold))))
;; show-paren
`(show-paren-match
((,class (:foreground ,magenta :background unspecified
- :weight unspecified))))
+ :weight bold))))
`(show-paren-mismatch
((,class (:foreground ,base02 :background ,red
- :weight unspecified))))
+ :weight bold))))
;; syslog-mode
`(syslog-ip ((,class (:background unspecified
@@ -1347,13 +1347,13 @@ customize the resulting theme."
;; mic-paren
`(paren-face-match
((,class (:foreground ,magenta :background unspecified
- :weight unspecified))))
+ :weight bold))))
`(paren-face-mismatch
((,class (:foreground ,base02 :background ,red
- :weight unspecified))))
+ :weight bold))))
`(paren-face-no-match
((,class (:foreground ,base02 :background ,red
- :weight unspecified))))
+ :weight bold))))
;; SLIME
`(slime-repl-inputed-output-face ((,class (:foreground ,red))))

6 comments on commit 86fd9b8

@bradwright

This comment has been minimized.

Show comment
Hide comment
@bradwright

bradwright Feb 23, 2014

Contributor

Could this not be an option? Are you sure everyone wants bold paren matching faces?

Contributor

bradwright replied Feb 23, 2014

Could this not be an option? Are you sure everyone wants bold paren matching faces?

@oscarfv

This comment has been minimized.

Show comment
Hide comment
@oscarfv

oscarfv Feb 23, 2014

Also it is worth mentioning that several popular fonts lack bold/italic variants. Other fonts (like Consolas, that I use) show little difference among bold/normal parens. And some text terminals cannot display bold/italic at all.

So IMHO this effect is nice to have, but we shouldn't rely too much on it for making text more visible than its surroundings.

Also it is worth mentioning that several popular fonts lack bold/italic variants. Other fonts (like Consolas, that I use) show little difference among bold/normal parens. And some text terminals cannot display bold/italic at all.

So IMHO this effect is nice to have, but we shouldn't rely too much on it for making text more visible than its surroundings.

@thomasf

This comment has been minimized.

Show comment
Hide comment
@thomasf

thomasf Feb 24, 2014

Collaborator

I do not use this Bolding. I have removed that and more in my personal child theme, might not have pushed that particular change to (https://github.com/thomasf/dotfiles-thomasf-emacs/blob/master/emacs.d/lisp/my-solarized.el). My general advice for making the solarized accent colors easy to distinguish would be to increase the font size but that is not always practical for everyone. Also, everything is optional (hello elisp).

Collaborator

thomasf replied Feb 24, 2014

I do not use this Bolding. I have removed that and more in my personal child theme, might not have pushed that particular change to (https://github.com/thomasf/dotfiles-thomasf-emacs/blob/master/emacs.d/lisp/my-solarized.el). My general advice for making the solarized accent colors easy to distinguish would be to increase the font size but that is not always practical for everyone. Also, everything is optional (hello elisp).

@thomasf

This comment has been minimized.

Show comment
Hide comment
@thomasf

thomasf Feb 24, 2014

Collaborator

One thing I eventually want to have is a couple of high level profiles that mostly set the intensity level of visual cues.

Collaborator

thomasf replied Feb 24, 2014

One thing I eventually want to have is a couple of high level profiles that mostly set the intensity level of visual cues.

@thomasf

This comment has been minimized.

Show comment
Hide comment
@thomasf

thomasf Feb 24, 2014

Collaborator

@oscarfv: Consolas is a really awesome font, ihmo it is a very good decision for a programming font to bold parens only slightly. I looked through bolded parens of 5-10 fonts before removing them from the match faces, a lot of very suitable programming fonts puts too much bold on parens.

Collaborator

thomasf replied Feb 24, 2014

@oscarfv: Consolas is a really awesome font, ihmo it is a very good decision for a programming font to bold parens only slightly. I looked through bolded parens of 5-10 fonts before removing them from the match faces, a lot of very suitable programming fonts puts too much bold on parens.

@thomasf

This comment has been minimized.

Show comment
Hide comment
@thomasf

thomasf Mar 14, 2014

Collaborator

There is now a custom option called solarized-use-less-bold that also removes bold from font-lock-builtin-face which is what I have been using for a very long while.. I also added an solarized-use-more-italic for those of us that uses fonts which have a good looking italic slant.

Collaborator

thomasf replied Mar 14, 2014

There is now a custom option called solarized-use-less-bold that also removes bold from font-lock-builtin-face which is what I have been using for a very long while.. I also added an solarized-use-more-italic for those of us that uses fonts which have a good looking italic slant.

Please sign in to comment.