Invalid face box: :line-width, 4, :color, "grey90", :style, nil

[wdenton]

I just recompiled Emacs from fresh source and to my surprise it looked vastly different, and really ugly. It turns out that solarized-theme (I use solarized-dark) isn't loading.

I get this warning:

Invalid face box: :line-width, 4, :color, "grey90", :style, nil

On trying a second time after executing (load-theme 'solarized-dark t) I get this:

Debugger entered--Lisp error: (error "Invalid face box" :line-width 2 :color "#002b36" :style unspecified)
  set-face-attribute(header-line #<frame init.org - GNU Emacs at ochre 0x55e181fe7328> :inverse-video unspecified :overline nil :underline "#073642" :foreground "#839496" :background "#002b36" :box (:line-width 2 :color "#002b36" :style unspecified))
  face-spec-set-2(header-line #<frame init.org - GNU Emacs at ochre 0x55e181fe7328> (:inverse-video unspecified :overline nil :underline "#073642" :foreground "#839496" :background "#002b36" :box (:line-width 2 :color "#002b36" :style unspecified)))
  face-spec-recalc(header-line #<frame init.org - GNU Emacs at ochre 0x55e181fe7328>)

... followed by much more.

I think it's because of this commit:

commit dcd755dabcf9ef95d6d0534c11c668f44c6f89c2
  Author: Eli Zaretskii <eliz@gnu.org>
  Date:   Thu Nov 30 17:17:02 2023 +0200
   
      Fix validation of :box face attribute
      
      * src/xfaces.c (Finternal_set_lisp_face_attribute): Fix the logic
      of validating the :box attribute.  The previous code would always
      allow invalid attributes of :box as long as the invalid attribute
      was the last in the list.  (Bug#67404)

[Dou-Meishi]

Same issue:

⛔ Error (use-package): solarized-theme/:config: Invalid face box: :line-width, 2, :color, "#fdf6e3", :style, unspecified

I tried several styles, including solarized-dark, solarized-light and solarized-light-high-contrast. All give above error.

[widefox]

Same. I suspect that commit as well.
It breaks all the Solarized themes, and several other themes.

[widefox]

There's this subsequent commit adding to that one:

commit 3cbe263b081eaa40753e122e5b98d74d9d9d0c9f
Author: Eli Zaretskii <eliz@gnu.org>
Date:   Fri Dec 1 14:15:30 2023 +0200

    Fix mode-line-inactive face

    * src/xfaces.c (Finternal_set_lisp_face_attribute): Fix validation
    of the :style attribute of :box.  Previously, nil for :style was not
    accepted, which causes 'mode-line-inactive' face to be rejected.
    (Bug#67567)