Bozhidar Batsov bbatsov

Organizations

@fosscourse @slim-template @toptal @rails-girls-sofia @clojure-emacs
bbatsov commented on pull request clojure-emacs/cider#1284
@bbatsov

CIDER already depends on the extra deps you've added. What's the point?

bbatsov commented on pull request clojure-emacs/cider#1284
@bbatsov

I would not run any tests on 24.1 and 24.2 as we'll never support them. It's just a waste of time. We care only about 24.3 to 24.5 and emacs-snapshot.

bbatsov commented on issue bbatsov/rubocop#2172
@bbatsov

So, I've added a new team - https://gratipay.com/rubocop/ Next step, how do I update the gratipay icon...

@bbatsov

I told myself - don't forget about those 2 and then I totally forgot about them. :-)

bbatsov commented on pull request bbatsov/rubocop#2188
@bbatsov

:+1:

@bbatsov
bbatsov merged pull request bbatsov/rubocop#2188
@bbatsov
Handle class methods in EmptyLineBetweenDefs
1 commit with 71 additions and 2 deletions
@bbatsov

Guess that in terms of symmetry it'd be better if this was a method of its own.

bbatsov commented on pull request bbatsov/rubocop#2188
@bbatsov

Yeah, looks good now. Just rebase it and we're good to go.

@bbatsov
bbatsov commented on issue bbatsov/rubocop#2190
@bbatsov

Hmm, I was under the impression that we made --auto-correct and --only play nice together. @jonas054 I guess I was wrong, right?

bbatsov commented on issue bbatsov/rubocop#2189
@bbatsov

We already have -a, as an alias for --auto-correct, so adding one more seems kind of redundant to me. @jonas054 Thoughts?

bbatsov commented on pull request bbatsov/rubocop#2188
@bbatsov

We have a mixin called OnMethodDef or something like this, which you should be using when having to deal with def and defs nodes.

@bbatsov
bbatsov merged pull request bbatsov/rubocop#2193
@bbatsov
Add support for more methods in Style/Next
1 commit with 60 additions and 3 deletions
bbatsov commented on pull request bbatsov/rubocop#2193
@bbatsov

Probably we should generate those examples in some loop.

bbatsov commented on pull request bbatsov/rubocop#2184
@bbatsov

Jonas makes a good point.

bbatsov commented on pull request bbatsov/rubocop#2191
@bbatsov

Is there a reason that these methods are not checked? If not, I will submit a PR to add them. Just an oversight.

@bbatsov
bbatsov merged pull request bbatsov/rubocop#2191
@bbatsov
Move next offense
2 commits with 260 additions and 252 deletions
@bbatsov
"Use next to skip iteration" reporting wrong location.
bbatsov commented on pull request bbatsov/rubocop#2188
@bbatsov

We should have a spec about the adjacent def & defs nodes.

bbatsov commented on issue clojure-emacs/cider#1281
@bbatsov

Yes. On Wednesday, August 26, 2015, Artur Malabarba notifications@github.com wrote: What was the old behavior again? Just use the first element of …

@bbatsov
Add an option to have the old connection dispatch
@bbatsov
Insert links to the README's troubleshooting section for all REPL warnings
@bbatsov
bbatsov commented on pull request bbatsov/rubocop#2170
@bbatsov

p test('aaa') { |x| x.upcase } Should produce an offense - if it currently doesn't, that's a bug. I guess I didn't understand your original remark.

bbatsov commented on pull request bbatsov/rubocop#2170
@bbatsov

Does running this make it clear? class A def something(x) yield(x) end end class B < A def something(x) puts x super(x, &:upcase) end end p B.new.s…

@bbatsov
FormatParameterMismatch should ignore escaped percent character
bbatsov commented on issue bbatsov/rubocop#2128
@bbatsov

Actually, it seems that this is fixed on master.