Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logging of serf agent messages when /bin/sh is not a symlinked bash. #17

Merged
merged 1 commit into from Jan 22, 2014

Conversation

Projects
None yet
2 participants
@jperville
Copy link

commented Jan 22, 2014

When running on a system where /bin/sh is not a symlink to /bin/bash (eg. Ubuntu), messages from the serf agent are displayed on the terminal rather than in $SERF_AGENT_LOG as expected. I traced the bug to the use of &>> in the service script, which according to "man bash" is shortcut to the more compatible >>$SERF_AGENT_LOG 2>&1.

@bbaugher

This comment has been minimized.

Copy link
Owner

commented Jan 22, 2014

Looks good, thanks

bbaugher added a commit that referenced this pull request Jan 22, 2014

Merge pull request #17 from jperville/bashism-agent-log-redirection
Fixed logging of serf agent messages when /bin/sh is not a symlinked bash.

@bbaugher bbaugher merged commit 8a4a8f0 into bbaugher:master Jan 22, 2014

@jperville jperville deleted the jperville:bashism-agent-log-redirection branch Jan 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.