Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #31

Merged
merged 1 commit into from Apr 23, 2015

Conversation

Projects
None yet
2 participants
@KensoDev
Copy link
Contributor

commented Apr 23, 2015

  • Making sure to follow Ruby naming conventions.
  • Making the directory creation DRY
  • No need for managing log roation in a template, use logrotate bookbook
  • Whitespace
Refactoring
* Making sure to follow Ruby naming conventions.
* Making the directory creation DRY
* No need for managing log roation in a template, use logrotate bookbook
* Whitespace

@bbaugher bbaugher added this to the 0.9.0 milestone Apr 23, 2015

@bbaugher

This comment has been minimized.

Copy link
Owner

commented Apr 23, 2015

Wow this looks really good, thanks! I'll test it out and if everything works I'll merge it in.

@bbaugher

This comment has been minimized.

Copy link
Owner

commented Apr 23, 2015

Tests all pass.

bbaugher added a commit that referenced this pull request Apr 23, 2015

@bbaugher bbaugher merged commit c5bf4b9 into bbaugher:master Apr 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.