Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Fn Project #43

Merged
merged 4 commits into from Nov 16, 2017
Merged

Adds support for Fn Project #43

merged 4 commits into from Nov 16, 2017

Conversation

@mjg123
Copy link
Contributor

@mjg123 mjg123 commented Nov 14, 2017

We would like to use JRestless to support running JAX-RS apps on Fn Projects

See Fn Project at: http//fnproject.io
See blog at: http://mjg123.github.io/2017/11/08/Jax-RS-on-Fn.html
See example project at: https://github.com/fnproject/fn-jrestless-example

Copy link
Owner

@bbilger bbilger left a comment

Hi @mjg123,
Awesome work! Thanks for your contribution.

Three things, though:

  1. The pull request does not build against master. The problem is that I am currently updating JRestless to work with Jersey 2.26 which introduced a few breaking changes: https://jersey.github.io/documentation/latest/user-guide.html#mig-2.26-injection-manager See: 94aee46
  2. Is it possible to use slf4j instead of writing to stderr, directly?
  3. What's the license of the code? Apache 2.0?

Loading

protected WrappedOutput onRequestFailure(Exception e,
WrappedInput wrappedInput,
@Nullable JRestlessContainerRequest jRestlessContainerRequest) {
System.err.println("request failed" + e.getMessage());
Copy link
Owner

@bbilger bbilger Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be logged via slf4j?

Loading

@mjg123
Copy link
Contributor Author

@mjg123 mjg123 commented Nov 15, 2017

Thanks for your quick attention! I'll get an update up today or tomorrow.

Loading

  Some breaking changes in this version of Jersey.
  Also sends a System.err.println via slf4j
@bbilger bbilger merged commit 698acfa into bbilger:master Nov 16, 2017
@bbilger
Copy link
Owner

@bbilger bbilger commented Nov 16, 2017

Hi @mjg123 ,
I merged the PR. Thanks again!

Notes:

  • After merging I realized that the tests were in the wrong location and didn't compile/pass. So I moved and fixed them: ca1bc17
  • I plan to release the next version of JRestless (0.6.0) - including this PR - this weekend.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants