-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize JSON::RPC #31
Conversation
azawawi
commented
Jan 18, 2017
- Modernize META.info to META6.json
- Add Test::META tests
- CI: Test on macOS and windows on 2016.12 and latest. Please enable AppVeyor support.
- Add missing LICENSE file.
… install test. Add macOS operating system
Thanks, I'll review your changes during weekend (not much free time after $dayjob). If we speak about modernization - this module was written in early Parrot VM era. It is full of antipatterns (exception based flow control, procedural design without proper requests isolation). And it is pretty much dead protocol - https://www.google.com/trends/explore?q=json-rpc,http%20rest . I have to estimate time required for proper refactoring (with support of parallel batch processing of course and switch to more polished modules like JSON::Fast) and decide what will be the future of this module. |
@bbkr Thanks for your time. I am using it for Odoo::Client so it is not dead as a protocol considering a big enterprise Odoo ERP is using it for integration work :) |
Please take a look at refactoring roadmap #32 . I think this should take about 2-3 weeks, including applying changes from your MR and enabling AppVeyor. |
Updated the roadmap. Thanks for your work 👍 |
Thanks 👍 |