Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused OS column from the drivers list #272

Closed
dennwc opened this issue Mar 26, 2019 · 0 comments
Closed

Drop unused OS column from the drivers list #272

dennwc opened this issue Mar 26, 2019 · 0 comments
Labels

Comments

@dennwc
Copy link
Member

dennwc commented Mar 26, 2019

OS column is currently printed in the driver list:

$ bblfshctl driver list
+------------+------------------------------------------+---------+--------+---------+--------+-------------+------------------------------+
|  LANGUAGE  |                  IMAGE                   | VERSION | STATUS | CREATED |   OS   |     GO      |            NATIVE            |
+------------+------------------------------------------+---------+--------+---------+--------+-------------+------------------------------+
| python     | docker://bblfsh/python-driver:latest     | v2.8.2  | beta   | 2 days  | alpine | 1.10-alpine | python:3.6-alpine            |
| csharp     | docker://bblfsh/csharp-driver:latest     | v1.4.1  | beta   | 6 days  |        | 1.10        | microsoft/dotnet:2.1-runtime |

But since we changed the build system this column has no effect on the driver and is probably outdated.

We should drop this column from the manifest and the driver list output.

@dennwc dennwc added the bug label Mar 26, 2019
dennwc pushed a commit to dennwc/bblfshd that referenced this issue Mar 26, 2019
Signed-off-by: Denys Smirnov <denys@sourced.tech>
dennwc pushed a commit to dennwc/bblfshd that referenced this issue Mar 26, 2019
Signed-off-by: Denys Smirnov <denys@sourced.tech>
dennwc pushed a commit that referenced this issue Mar 26, 2019
Signed-off-by: Denys Smirnov <denys@sourced.tech>
dennwc pushed a commit to dennwc/bblfshd that referenced this issue Mar 27, 2019
We removed the column data in bblfsh#272, but left the header in place.

Signed-off-by: Denys Smirnov <denys@sourced.tech>
dennwc pushed a commit that referenced this issue Mar 27, 2019
We removed the column data in #272, but left the header in place.

Signed-off-by: Denys Smirnov <denys@sourced.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant