Permalink
Browse files

Add .rvmrc and Gemfile to make it easy to use bundler and rvmrc to ma…

…nage dev dependencies for this project.
  • Loading branch information...
1 parent 337740f commit a6d62480505ee31b40b282bfd068a97db1821a53 @myronmarston myronmarston committed Apr 8, 2011
Showing with 7 additions and 4 deletions.
  1. +1 −0 .gitignore
  2. +1 −0 .rvmrc
  3. +4 −0 Gemfile
  4. +1 −4 Rakefile
View
@@ -19,3 +19,4 @@ rdoc
pkg
## PROJECT::SPECIFIC
+Gemfile.lock
View
1 .rvmrc
@@ -0,0 +1 @@
+rvm use 1.9.2@webmock --create
@raggi

raggi May 20, 2011

This makes it harder to test against multiple rubies and also makes it annoying for other people to work on. Can't you just keep this locally because at the end of the day, this is /your choice/ not everyones?

@myronmarston

myronmarston May 20, 2011

Collaborator

Feel free to submit a pull request removing this file and git ignoring. I'll leave it up to the other webmock committers to decide to merge the PR or not, but I'm totally fine with it either way.

@justinko

justinko May 20, 2011

You could always go halfway and just set the gemset (which will use your default ruby):

https://github.com/rspec/rspec-dev/blob/master/.rvmrc

@raggi

raggi May 20, 2011

the point is, i don't want rvm prompting me, or to use a gemset. rvm isn't the only way.

@raggi

raggi May 20, 2011

myronmarston - if i get around to fixing things up for em-http-request beta.3 i'll include this as a separate commit

@jcf

jcf May 20, 2011

Collaborator

This makes it harder to test against multiple rubies

I've recently added a rake task (rvm:specs) to test WebMock using all supported versions of Ruby. There's some setup involved but that's documented in the read me.

the point is, i don't want rvm prompting me

What's the prompt your getting from RVM? Is it related to trusting the .rvmrc file?

You could prevent RVM from using project-specific .rvmrc files using:

rvm_project_rvmrc=0

…or perhaps you could tell RVM not to trust the .rvmrc file in this project?

TL;DR

I know I'm happy with this .rvmrc file and it sounds like @myronmarston is too.

View
@@ -0,0 +1,4 @@
+source "http://rubygems.org/"
+gemspec
+
+gem 'jeweler'
View
@@ -36,10 +36,6 @@ Rake::TestTask.new(:test) do |test|
test.warning = false
end
-task :spec => :check_dependencies
-
-task :test => :check_dependencies
-
task :default => [:spec, :test]
require 'rake/rdoctask'
@@ -51,3 +47,4 @@ Rake::RDocTask.new do |rdoc|
rdoc.rdoc_files.include('README*')
rdoc.rdoc_files.include('lib/webmock/webmock.rb')
end
+

0 comments on commit a6d6248

Please sign in to comment.