Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

URI from after_request callback cannot be used to stub identical request later #134

Closed
myronmarston opened this Issue Sep 22, 2011 · 3 comments

Comments

Projects
None yet
2 participants
Collaborator

myronmarston commented Sep 22, 2011

I've been trying to figure out the source of this VCR issue.

The URI VCR gets from WebMock's after_request callback cannot be used later to stub the same request (i.e. on a later test run).

I've come up with a gist that demonstrates the issue. The %2B from the original request gets decoded as + in the URI on the request in the after_request callback, and then when I use this exact URI to stub the request later it fails.

Owner

bblimke commented Sep 24, 2011

This is due to addressable being inconsistent in normalizing % expressions. It's different for %20 and different for %2B.
I created an issue in addressable: sporkmonger/addressable#50

Collaborator

myronmarston commented Sep 25, 2011

Thanks!

On Sep 24, 2011, at 10:22 AM, Bartosz Blimke
reply@reply.github.com
wrote:

This is due to addressable being inconsistent in normalizing % expressions. It's different for %20 and different for %2B.
I created an issue in addressable: sporkmonger/addressable#50

Reply to this email directly or view it on GitHub:
#134 (comment)

@bblimke bblimke referenced this issue in sporkmonger/addressable Dec 28, 2012

Closed

Inconsistent normalization of % escaping #50

Owner

bblimke commented Mar 6, 2013

It looks like my recent changes fixed this issue too. @myronmarston can you please confirm and close?

@bblimke bblimke closed this Mar 7, 2013

@bblimke bblimke reopened this Mar 7, 2013

@bblimke bblimke closed this Sep 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment