Typhoeus with POST requests breaks #140

Closed
pierrevalade opened this Issue Dec 2, 2011 · 6 comments

Comments

Projects
None yet
2 participants

If you try to use Webmock with Typhoeus for POST requests, there is an issue because of the :params option of Typhoeus.

Typhoeus::Request.post(url, :params => {:hello => 'world'})

the params are not correctly passed to the request in typhoeus_hydra_adapter.rb

seems like it's kind of hard to fix because of the way Typhoeus handle params internally.

Owner

bblimke commented Dec 3, 2011

Thanks for info. Indeed :params are not supported. It will be difficult to add support since params are used inside Typhoeus::Easy not Typhoeus::Hydra.

Owner

bblimke commented Dec 3, 2011

As I understand, you are only not able to stub requests based on params or does it really break something?

When you try to use it breaks because of :
https://github.com/bblimke/webmock/blob/master/lib/webmock/request_pattern.rb#L155
where body is nil in this case.

Owner

bblimke commented Dec 18, 2011

Can you have a look if it works for you with WebMock from master branch?

Owner

bblimke commented Jan 22, 2012

I assume it works now. Closing.

Owner

bblimke commented Jan 22, 2012

Close

@bblimke bblimke closed this Jan 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment