HTTPClient 2.2.6 changed Message::Headers.init_response #203

Closed
Odaeus opened this Issue Aug 14, 2012 · 3 comments

Comments

Projects
None yet
3 participants

Odaeus commented Aug 14, 2012

Hi,

HTTPClient just did a new point release and changed the Message::Headers.init_response method arity causing an exception in WebMock. I've asked them if they consider this a public interface.

The trace is:

Failure/Error: importer.import
ArgumentError:
  wrong number of arguments (1 for 2)
  # /home/andrew/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/httpclient-2.2.6/lib/httpclient/http.rb:202:in `init_response'
  # /home/andrew/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/webmock-1.8.7/lib/webmock/http_lib_adapters/httpclient_adapter.rb:99:in `build_httpclient_response'
  # /home/andrew/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/webmock-1.8.7/lib/webmock/http_lib_adapters/httpclient_adapter.rb:47:in `do_get_with_webmock'

Thanks,
Andrew

Odaeus closed this Aug 14, 2012

Odaeus commented Aug 14, 2012

@nahi has already published a fix in version 2.2.7 of httpclient so closing this issue.

Owner

bblimke commented Aug 14, 2012

Thank you for handling this issue! :)

nahi commented Aug 15, 2012

Apologize and thank you!
On Aug 15, 2012 1:34 AM, "Bartosz Blimke" notifications@github.com wrote:

Thank you for handling this issue! :)


Reply to this email directly or view it on GitHubhttps://github.com/bblimke/webmock/issues/203#issuecomment-7731570.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment