after_request callback has a blank body when making an excon request with a response block #246

Closed
myronmarston opened this Issue Jan 18, 2013 · 1 comment

Comments

Projects
None yet
2 participants
Collaborator

myronmarston commented Jan 18, 2013

I discovered this bug while troubleshooting vcr/vcr#245.

Excon supports a response_block feature. When it is used, it streams the response through the block rather than appending the read content to the in-memory body string on the response object.

As a result, response.body is a blank string, and VCR is recording it improperly.

WebMock's excon adapter needs to be fixed to support excon requests that use the response block feature.

myronmarston added a commit to vcr/vcr that referenced this issue Jan 18, 2013

Add a pending spec for #245.
It's a bug in webmock (bblimke/webmock#246). This
spec will help prevent future regressions.

Closes #245.
Owner

bblimke commented Feb 17, 2013

@myronmarston Thank you for reporting that. I just released version 1.9.2 which fixes that.

@bblimke bblimke closed this Mar 5, 2013

plukevdh added a commit to plukevdh/vcr that referenced this issue Apr 22, 2013

Add a pending spec for #245.
It's a bug in webmock (bblimke/webmock#246). This
spec will help prevent future regressions.

Closes #245.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment