Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

excon broken in 1.11 #261

Closed
masterkain opened this Issue · 9 comments

5 participants

@masterkain
Excon.new("http://myapp", mock: Rails.env.test?).request(idempotent: true, expects: expected_status_codes, method: verb, path: path, query: params)
     ArgumentError:
       wrong number of arguments (2 for 1)
     # /Users/kain/.rvm/gems/ruby-2.0.0-p0@myapp/gems/webmock-1.11.0/lib/webmock/http_lib_adapters/excon_adapter.rb:138:in `new'
     # /Users/kain/.rvm/gems/ruby-2.0.0-p0@myapp/gems/excon-0.17.0/lib/excon.rb:102:in `new'
@bblimke
Owner

Can you please try with latest Excon version?

@masterkain

I recall I already did, the gem version listed in the stacktrace was one of the downgrades I did in order to check this error.
The latest excon clashes badly also with the VCR/WebMock combo, I'll try again when I have few minutes.

@bblimke
Owner

Latest Excon 0.19.x should be fine with WebMock. I think VCR is not yet compatible with Excon >= 0.17 and WebMock >= 1.11.

@danielfone

@bblimke I have this issue too, since heroku-api is currently locking excon to ~> 0.16.10. Since WebMock appears to be broken with this version of excon, would it be appropriate to update the gemspec to reflect this?

@bblimke
Owner

@danielfone gemspec should be updated, good point.

@gottfrois

Hi,

Having the same issue working with excon 0.13.4. When do you think the gemspec will be updated ?

@bblimke
Owner

Gemspec is now updated.

@bblimke bblimke closed this
@tommoor

Hey guys, I see this was marked as resolved and gemspec updated but I still get the same error as above - is it just that the heroku gem and webmock are incompatible?

@bblimke
Owner

I just released 1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.