webmock/rspec should not require 'rspec/expectations' #64

Open
bblimke opened this Issue Nov 13, 2010 · 5 comments

Projects

None yet

3 participants

@bblimke
Owner
bblimke commented Jul 31, 2011

WebMock uses RSpec::Expectations::ExpectationNotMetError to create RSpec failure instead of error when an expectation is not met.
Removing dependency on 'rspec/expectations' would mean 'rspec/expectations' would have to be loaded before 'webmock/rspec'.
For now usage of other ExpectationFrameworkAdapter's other than the RSpec default one is not common.
Imo it's best to keep this change on hold until usage of alternative ExpectationFrameworkAdapters gets popular and requiring 'rspec/expectations' by WebMock becomes a problem.

@nikosd
nikosd commented Dec 13, 2011

@bblimke please check out this comment : 9d255f1#commitcomment-789795

@bblimke
Owner
bblimke commented Mar 6, 2013

@myronmarston has anything changed in RSpec recently? Have any other expectation frameworks adapters been added? Is there now a unified way to trigger a failure no matter what expectation framework is used?

@bblimke
Owner
bblimke commented Sep 28, 2014

@myronmarston does this issue still make sense? are people really using other expectations frameworks used with rspec, to make it worth for WebMock not to include rspec/expectations?

@myronmarston
Collaborator

@myronmarston does this issue still make sense? are people really using other expectations frameworks used with rspec, to make it worth for WebMock not to include rspec/expectations?

I believe this issue is still valid. While it's not very common to use rspec w/o rspec-expectations, it does occur and IMO it's wrong to assume the user wants it. In the absence of user requests to change this it's completely reasonable to punt on it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment