Webmock regex stubs break with addressable 2.2.5 #84

Closed
JangoSteve opened this Issue Apr 12, 2011 · 2 comments

Comments

Projects
None yet
2 participants
@JangoSteve

I'm actually not sure whether this is a bug with webmock or with addressable, but it seems that unless we specify addressable 2.2.4 in our Gemfile, our regex request stubs cause an error (this is with Ruby 1.9.2, Rails 3.0.3, RSpec 2.4.0, Webmock 1.6.2).

Something like:

stub_request(:any, /s3\.amazonaws\.com.*/)

In our before(:each) block causes this error in our specs:

RuntimeError:
   can't modify frozen object

This only happens for requests stubbed with a regex, and only happens with addressable 2.2.5. Not sure if maybe this "less frozen, more speed" addressable commit has anything to do with it.

@myronmarston

This comment has been minimized.

Show comment Hide comment
@myronmarston

myronmarston Apr 12, 2011

Collaborator

It looks like this is a bug in addressable:

sporkmonger/addressable#33

Collaborator

myronmarston commented Apr 12, 2011

It looks like this is a bug in addressable:

sporkmonger/addressable#33

@JangoSteve

This comment has been minimized.

Show comment Hide comment
@JangoSteve

JangoSteve Apr 12, 2011

Sure enough. That pull request from addressable solved it. Thanks!

Sure enough. That pull request from addressable solved it. Thanks!

@JangoSteve JangoSteve closed this Apr 12, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment