Match EM::HttpRequest Hash bodies #125

Merged
merged 1 commit into from Aug 17, 2011

Conversation

Projects
None yet
2 participants
@daveyeu
Contributor

daveyeu commented Aug 17, 2011

Here's the fix that simply changes the generated request signatures rather than altering the request pattern matcher.

I tested it against em-http-request 0.3.0 and 1.0.0.beta.4, which was green except for the em-synchrony tests, but it looks like a bug in that library (em-synchrony seems to assume em-http-request < 1.0.0).

Thanks.

Dave

@bblimke

This comment has been minimized.

Show comment Hide comment
@bblimke

bblimke Aug 17, 2011

Thank you! Everything tested and ready to merge. I like pull requests like this one :)
Have you tried em-synchrony 0.3.0 beta? Version 0.2.0 doesn't work with em-http-request 1.0.0 beta.

Thank you! Everything tested and ready to merge. I like pull requests like this one :)
Have you tried em-synchrony 0.3.0 beta? Version 0.2.0 doesn't work with em-http-request 1.0.0 beta.

bblimke added a commit that referenced this pull request Aug 17, 2011

Merge pull request #125 from groupme/em-http-request
Match EM::HttpRequest Hash bodies

@bblimke bblimke merged commit 5f8d898 into bblimke:master Aug 17, 2011

@bblimke

This comment has been minimized.

Show comment Hide comment
@bblimke

bblimke Aug 17, 2011

Owner

Just released as 1.7.4

Owner

bblimke commented Aug 17, 2011

Just released as 1.7.4

@daveyeu

This comment has been minimized.

Show comment Hide comment
@daveyeu

daveyeu Aug 18, 2011

Contributor

Awesome, thanks!

Contributor

daveyeu commented Aug 18, 2011

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment