Fix various warnings. #132

Merged
merged 1 commit into from Sep 8, 2011

Projects

None yet

3 participants

@stephencelis

I like to run my test suite with -w when possible. This commit cleans up the warnings I was encountering by initializing instance variables (or checking if they're defined), avoiding the overshadowing of a local variable in a block, and not assigning an unused local variables.

@bblimke
Owner

Looks good! Thank you for this patch, I may start using -w option too :)

@bblimke bblimke merged commit 76eefec into bblimke:master Sep 8, 2011
@myronmarston
Collaborator

If you decide to start using -w, you might be interested in the technique I used w/ VCR to isolate the warnings output to just warnings generated by VCR itself, and to fail the build if VCR generates warnings. I blogged about it. Note that the current version of my capture_warnings,rb file is a bit different from what I had put in the blog post.

@bblimke
Owner

Thanks Myron. I'll have a look at your solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment