Support for native typhoeus timeouts #143

Merged
merged 1 commit into from Jan 3, 2012

Conversation

Projects
None yet
2 participants
Contributor

mrsimo commented Jan 2, 2012

With this patch the typhoeus way of checking timeouts works. The way they check timeouts is with the curl_return_code

https://github.com/dbalatero/typhoeus/blob/master/lib/typhoeus/response.rb#L100

Owner

bblimke commented Jan 3, 2012

Looks good. I thought it was based on response code 0 before, but maybe it was wrong from the beginning.

Owner

bblimke commented Jan 3, 2012

code + test = merge to master :) cheers!

bblimke added a commit that referenced this pull request Jan 3, 2012

Merge pull request #143 from mrsimo/master
Support for native typhoeus timeouts

@bblimke bblimke merged commit ae3f0ea into bblimke:master Jan 3, 2012

Contributor

mrsimo commented Jan 4, 2012

Thanks a lot! Any idea when this will get into a release? It's not terribly urgent, but we found the bug while developing a gem and would like to test it properly :) Cheers!

Owner

bblimke commented Jan 4, 2012

It was just released as 1.7.9 :) Cheers.

Contributor

mrsimo commented Jan 4, 2012

That was quick! Thanks a lot :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment