Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

net_http.rb: StubSocket needs read_timeout for aws-sdk #149

Merged
merged 1 commit into from Jan 22, 2012

Conversation

Projects
None yet
2 participants
Contributor

godfat commented Jan 16, 2012

Sorry that I failed to find out how to reproduce this in a simple
way without using aws-sdk, ending up with Net::WebMockNetBufferedIO
instead of StubSocket. aws-sdk is maintaining a connection pool which
is too complicated and I am tired of digging into it. Time to sleep...

Thanks!

net_http.rb: StubSocket needs read_timeout for aws-sdk
Sorry that I failed to find out how to reproduce this in a simple
way without using aws-sdk, ending up with Net::WebMockNetBufferedIO
instead of StubSocket. aws-sdk is maintaining a connection pool which
is too complicated and I am tired of digging into it. Time to sleep...

Thanks!
Owner

bblimke commented Jan 22, 2012

Would be good to have a test for it, but if this accessor is the only thing to make it work with aws sdk, then it's fine.
Thank you for investigating the issue and finding the solution!

bblimke added a commit that referenced this pull request Jan 22, 2012

Merge pull request #149 from godfat/read_timeout
net_http.rb: StubSocket needs read_timeout for aws-sdk

@bblimke bblimke merged commit a3e4104 into bblimke:master Jan 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment